fixed content_length and status always ints #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 82.99% 83.06% +0.06%
==========================================
Files 37 37
Lines 1758 1771 +13
==========================================
+ Hits 1459 1471 +12
- Misses 299 300 +1
Continue to review full report at Codecov.
|
lupengamzn
reviewed
Apr 29, 2021
| ret.status = status; | ||
| } | ||
| if (res.headers && res.headers['content-length']) { | ||
| ret.content_length = safeParseInt(res.headers['content-length']); |
There was a problem hiding this comment.
Should we keep recording the content-length even if it's 0?
There was a problem hiding this comment.
Yes we should IMO, content-length can be 0 if there is a response with an empty body, which could still be valuable for a customer to know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#385
Description of changes:
Ensures
content_lengthandstatusattributes are always integers, as specified in our docs. Also did some refactoring to reduce repeated code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.