Fix crash when http/https libraries use getters #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes aws#433 This works around an issue when using esbuild to bundle (e.g. using aws-lambda-nodejs) The fix is adapted from: follow-redirects/follow-redirects#146
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
- Coverage 82.71% 82.70% -0.01%
==========================================
Files 36 36
Lines 1741 1740 -1
==========================================
- Hits 1440 1439 -1
Misses 301 301
Continue to review full report at Codecov.
|
srprash
approved these changes
Jun 1, 2021
|
@willarmiros can we get a release soon that includes this? thanks! |
|
Sorry for the delay on this @cnuss - should have a release out soon! |
|
thanks @willarmiros !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #433
Description of changes:
This works around an issue when using esbuild to bundle (e.g. using aws-lambda-nodejs)
The fix is adapted from:
follow-redirects/follow-redirects#146
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
fixes #433