Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved @aws-sdk/types to peer dependencies to resolve incompatibilities #449

Closed
wants to merge 1 commit into from
Closed

Moved @aws-sdk/types to peer dependencies to resolve incompatibilities #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
202 changes: 129 additions & 73 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
"private": true,
"license": "Apache-2.0",
"devDependencies": {
"@aws-sdk/config-resolver": "^3.4.1",
"@aws-sdk/middleware-stack": "^3.3.0",
"@aws-sdk/node-config-provider": "^3.4.1",
"@aws-sdk/smithy-client": "^3.4.1",
"@aws-sdk/config-resolver": "^3.18.0",
"@aws-sdk/middleware-stack": "^3.18.0",
"@aws-sdk/node-config-provider": "^3.18.0",
"@aws-sdk/smithy-client": "^3.18.0",
"@aws-sdk/types": "^3.18.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean ^3.0.0 to maximize compatibility?

Suggested change
"@aws-sdk/types": "^3.18.0",
"@aws-sdk/types": "^3.0.0",

"@hapi/hapi": "^20.0.0",
"@types/chai": "^4.2.12",
"@types/koa": "^2.11.3",
Expand Down
4 changes: 3 additions & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@
"test": "test"
},
"//": "@types/cls-hooked is exposed in API so must be in dependencies, not devDependencies",
"peerDependencies": {
"@aws-sdk/types": "^3.0.0"
},
Comment on lines 24 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"//": "@types/cls-hooked is exposed in API so must be in dependencies, not devDependencies",
"peerDependencies": {
"@aws-sdk/types": "^3.0.0"
},
"peerDependencies": {
"@aws-sdk/types": "^3.0.0"
},
"//": "@types/cls-hooked is exposed in API so must be in dependencies, not devDependencies",

"dependencies": {
"@aws-sdk/types": "^3.4.1",
"@aws-sdk/service-error-classification": "^3.4.1",
"@types/cls-hooked": "^4.3.3",
"atomic-batcher": "^1.0.2",
Expand Down