Fastify sdk contrib

[jorgevrgs]

Issue #, if available:

Description of changes:

Add X-Ray plugin for Fastify

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[willarmiros]

Hi @jorgevrgs,

Thanks for contributing this instrumentation! Do you have any vision or plan for longer-term support for the instrumentation? Generally speaking we do not maintain the instrumentations in the sdk_contrib, so it would be nice to know someone with more expertise on the framework is able to help out with customer issues if they come in.

Also, we are advising newcomers to X-Ray to try out using OpenTelemetry JS, which already has an instrumentation for fastify. So we also don't want to be unnecessarily duplicating instrumentation options if the OpenTelemetry one would be suitable. Let me know what you think.

[jorgevrgs]

Hi @jorgevrgs,

Thanks for contributing this instrumentation! Do you have any vision or plan for longer-term support for the instrumentation? Generally speaking we do not maintain the instrumentations in the sdk_contrib, so it would be nice to know someone with more expertise on the framework is able to help out with customer issues if they come in.

Also, we are advising newcomers to X-Ray to try out using OpenTelemetry JS, which already has an instrumentation for fastify. So we also don't want to be unnecessarily duplicating instrumentation options if the OpenTelemetry one would be suitable. Let me know what you think.

I checked the contribution guide about the support requirement. Yes, I can help you to bring support, but if you have someone in mind please invite them. It would be great to have more people contributing here.

[willarmiros]

Hi @jorgevrgs can you fix the failing CI tests? Then I can take a look

[willarmiros]

Looks like there are still some errors, possibly related to the lerna config. I would recommend bootstrapping & running tests locally to be sure they pass

[jorgevrgs]

Looks like there are still some errors, possibly related to the lerna config. I would recommend bootstrapping & running tests locally to be sure they pass

Checking it, thanks for the info. Fixing ASAP.

[willarmiros]

Hmm seems to still be failing - try running the same commands that the CI runs (found here:

aws-xray-sdk-node/.github/workflows/pr-build.yml

Lines 45 to 47 in f432b2d

	npx lerna bootstrap --hoist
	npx lerna run compile
	npx lerna run test

) locally from the root of the repo. I guess that's the best way to avoid these snags

[jorgevrgs]

Getting this error:

lerna ERR! npm run test exited 1 in 'aws-xray-sdk-mysql' lerna WARN complete Waiting for 4 child processes to exit. CTRL-C to exit immediately.

I will sync branches to check what's wrong.

[jorgevrgs]

Hmm seems to still be failing - try running the same commands that the CI runs (found here:

aws-xray-sdk-node/.github/workflows/pr-build.yml

Lines 45 to 47 in f432b2d

	npx lerna bootstrap --hoist
	npx lerna run compile
	npx lerna run test

) locally from the root of the repo. I guess that's the best way to avoid these snags

Done:

[codecov-commenter]

Codecov Report

Merging #523 (8697f35) into master (f432b2d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          36       36           
  Lines        1758     1758           
=======================================
  Hits         1448     1448           
  Misses        310      310           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[willarmiros]

LGTM! Thanks for getting the CI to green and addressing other comments