Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS declaration file for SegmentEmitter #586

Merged

Conversation

carolabadeer
Copy link
Contributor

Issue #, if available: #576

Description of changes: This PR adds a TypeScript declaration file (.d.ts) for the SegmentEmitter module to fix TS errors reported in the issue above.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carolabadeer carolabadeer requested a review from a team as a code owner April 24, 2023 18:59
@carolabadeer carolabadeer force-pushed the segment-emitter-TS-declaration branch from 57073da to 3e2e448 Compare April 25, 2023 22:45
@codecov-commenter
Copy link

Codecov Report

Merging #586 (5626f8b) into master (bdeeaf6) will not change coverage.
The diff coverage is n/a.

❗ Current head 5626f8b differs from pull request most recent head 3e2e448. Consider uploading reports for the commit 3e2e448 to get more accurate results

@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1794     1794           
=======================================
  Hits         1496     1496           
  Misses        298      298           

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolabadeer carolabadeer merged commit eebda75 into aws:master Apr 26, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants