Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dependency override. Npm 8 in workflows. #607

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Jul 18, 2023

  • Updated the workflows to use npm v8.
  • As a better practice, switched to using npm ci (clean install) instead of npm install in the workflows. This way we are not updating the package-lock.json on the fly, rather using the packages specified in the lock file.
  • Updated to use overrides for explicitly bumping the semver version in cls-hooked.
  • Used npm v8 to generate newer package-lock.json. Verified that the semver version was bumped.
  • Now the SDK should be built using npm v8.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@srprash srprash requested a review from a team as a code owner July 18, 2023 23:40
@codecov-commenter
Copy link

Codecov Report

Merging #607 (61eedd2) into master (3c9d946) will not change coverage.
The diff coverage is n/a.

❗ Current head 61eedd2 differs from pull request most recent head 3865ee1. Consider uploading reports for the commit 3865ee1 to get more accurate results

@@           Coverage Diff           @@
##           master     #607   +/-   ##
=======================================
  Coverage   83.38%   83.38%           
=======================================
  Files          37       37           
  Lines        1794     1794           
=======================================
  Hits         1496     1496           
  Misses        298      298           

Copy link
Contributor

@carolabadeer carolabadeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srprash srprash merged commit cfcb476 into aws:master Jul 19, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants