fix(core): capture command data for SDK v3 clients #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #611 +/- ##
=======================================
Coverage 83.38% 83.38%
=======================================
Files 37 37
Lines 1794 1794
=======================================
Hits 1496 1496
Misses 298 298 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you so much for creating this PR to add onto the implementation in #527! Left a few small comments, but otherwise everything looks good!
carolabadeer
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #460
Description of changes:
Changes based on @SergeyPoluektov's PR: #527 since it looks abandoned.
I simply validated their changes, and added the requested unit test to this PR. The test validates that command inputs and outputs get mapped correctly into the generated segments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.