simple support for mysql2 promise version of query #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on unit tests... |
haotianw465
approved these changes
Oct 24, 2018
|
Thank you for your contribution. I have merged this PR and will prepare a release soon. |
|
Any clue on when this will be released? 🤔 Edit: Ok unrelated to this PR, I got error on high level promise support #6 (comment) |
|
This is in 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Missing support for mysql2 promises.
Description of changes:
The change in
patchCreateConnection()detects a Promise and patches through to the actual Connection object.The change in
resolveArguments()adds support for passing{sql,values}as a single argument toquery(), which is supported by mysql2.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.