Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated @aws-sdk package dependencies #621

Merged

Conversation

carolabadeer
Copy link
Contributor

@carolabadeer carolabadeer commented Oct 19, 2023

Issue #, if available: #620

  • Internally reported - @aws-sdk/service-error-classification module not found error when using pnpm

Description of changes:
A few @aws-sdk/* packages have been renamed to @smithy/*. This PR updates the name of these packages to ensure customers do not get errors while these deprecated dependencies of the X-Ray SDK are being installed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a9f999) 83.41% compared to head (7ba215e) 83.41%.

❗ Current head 7ba215e differs from pull request most recent head 666cbcd. Consider uploading reports for the commit 666cbcd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #621   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          37       37           
  Lines        1797     1797           
=======================================
  Hits         1499     1499           
  Misses        298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carolabadeer carolabadeer marked this pull request as ready for review October 20, 2023 23:52
@carolabadeer carolabadeer requested a review from a team as a code owner October 20, 2023 23:52
@wangzlei wangzlei merged commit 8912bb3 into aws:master Oct 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants