support for pg Promises #64
Conversation
update captureQuery to extract query object when result is a Promise
| if (this.queryQueue.length === 0) { | ||
| query = this.activeQuery; | ||
| } else { | ||
| query = this.queryQueue[this.queryQueue.length-1]; |
There was a problem hiding this comment.
Could you put some comments on what this line mean?
|
Looks good to me, posted a minor question. |
| } else { | ||
| args.sql = argsObj[0]; | ||
| args.values = typeof argsObj[1] !== 'function' ? argsObj[1] : null; | ||
| args.callback = !args.values ? argsObj[1] : (typeof argsObj[2] === 'function' ? argsObj[2] : undefined); |
There was a problem hiding this comment.
Should the recent fix for mysql also apply here? #66
There was a problem hiding this comment.
Hi, any update on this? Please let me know your thoughts.
There was a problem hiding this comment.
I updated it in my latest commit: 1474129
There was a problem hiding this comment.
sorry for the confusion. My question is that should the change typeof argsObj[1] === 'function' ? on mysql_p.js also be applied to postgres_p.js file here?
There was a problem hiding this comment.
Yes, I think it should.
# Conflicts: # packages/mysql/lib/mysql_p.js
|
Do you need anything additional for this to be merged? |
|
Thank you for your contribution. I have merged the pull request. Will prepare for a release as soon as possible. |
Issue #, if available:
Missing support for pg Promises.
Description of changes:
Restructured code to be parallel with mysql and added logic to handle case when
__query()returns a Promise.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.