Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask & Django create subsegments only if in LambdaContext & Lambda Env #139

Merged
merged 1 commit into from Feb 28, 2019

Conversation

chanchiem
Copy link
Contributor

@chanchiem chanchiem commented Feb 27, 2019

Issue #, if available:
#138

Description of changes:
Middles should automatically generate subsegments if we are in a Lambda Environment and Lambda Context, otherwise generate Segments.

Added unit tests to make sure the default behavior is to generate segments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…nvironment (aws#138)

* Added unit tests to ensure these frameworks generate segmentby default and
subsegments if in lambda context and environment.
Copy link

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! :shipit:

@chanchiem chanchiem merged commit e9d3746 into aws:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants