Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test with Python3.7 #157

Merged
merged 2 commits into from Jun 3, 2019
Merged

Enable test with Python3.7 #157

merged 2 commits into from Jun 3, 2019

Conversation

luzfcb
Copy link
Contributor

@luzfcb luzfcb commented May 20, 2019

Issue:
#156

In November of last year, AWS Lambda included official support for Python3.7 on Lambda, however, this project is not being tested using Python3.7.

Description of changes:

  • Change the Travis-ci configuration to use Ubuntu Xenial (16.04) instead of Ubuntu Trusty (14.04) as base OS to allow run the tests with Python3.7. Python 3.7 is not available on Ubuntu 14.04, and 14.04 already reached the End of Life status.
  • Update the 'tox' configurations and Travis-ci configuration to enable test with Python3.7

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@luzfcb
Copy link
Contributor Author

luzfcb commented May 20, 2019

The tests fail but are unrelated to my changes

@awssandra
Copy link

We've run into some flakey test issues before. We'll take a look to see what's going on.

@chanchiem
Copy link
Contributor

Investigating the flaky test to see if we can get that resolved. It seemed to have failed in pr #158 as well

@chanchiem chanchiem self-assigned this May 22, 2019
@chanchiem
Copy link
Contributor

chanchiem commented May 31, 2019

Tested this PR locally and all tests seem to pass except the flaky one; it seems to be failing for all versions. Will need to investigate flaky tests as a separate issue. Although it's strange that it seemed to have failed through all the versions. Perhaps the failed test is an indication of an actual bug.

Another thing is that for some reason Travis CI isn't able to download Python 3.7 and run the test for that version either. There does seem to be a workaround here but we will have to investigate further to make sure everything works correctly. This PR in itself looks fine and will be pushed as soon as we can get these other issues fixed.

We really appreciate your PR and hope to get these issues resolved as soon as possible.

Edit:
After rerunning the travis CI on the latest stable release commit, the same test seems to be failing now when it used to be passing.
Test just ran: https://travis-ci.org/aws/aws-xray-sdk-python/builds/502178680
Last test ran: https://travis-ci.org/aws/aws-xray-sdk-python/builds/502170147

These are both for the same branch but the first one was ran a few minutes ago while the latter was ran several months ago. Perhaps there was a modification in one of our dependencies

@luzfcb
Copy link
Contributor Author

luzfcb commented May 31, 2019

@chanchiem I changed the configuration to make Travis-ci use Ubuntu 16.04 instead of 14.04 to run the tests.

@chanchiem
Copy link
Contributor

Everything looks good! Thanks for your contribution!

Copy link
Contributor

@chanchiem chanchiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for 3.7 Everything looks good!

@chanchiem
Copy link
Contributor

Had tested on local Python test as well as on Lambda through Serverless and manual X-Ray invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants