New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test with Python3.7 #157
Conversation
The tests fail but are unrelated to my changes |
We've run into some flakey test issues before. We'll take a look to see what's going on. |
Investigating the flaky test to see if we can get that resolved. It seemed to have failed in pr #158 as well |
Tested this PR locally and all tests seem to pass except the flaky one; it seems to be failing for all versions. Will need to investigate flaky tests as a separate issue. Although it's strange that it seemed to have failed through all the versions. Perhaps the failed test is an indication of an actual bug. Another thing is that for some reason Travis CI isn't able to download Python 3.7 and run the test for that version either. There does seem to be a workaround here but we will have to investigate further to make sure everything works correctly. This PR in itself looks fine and will be pushed as soon as we can get these other issues fixed. We really appreciate your PR and hope to get these issues resolved as soon as possible. Edit: These are both for the same branch but the first one was ran a few minutes ago while the latter was ran several months ago. Perhaps there was a modification in one of our dependencies |
@chanchiem I changed the configuration to make Travis-ci use Ubuntu 16.04 instead of 14.04 to run the tests. |
Everything looks good! Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for 3.7 Everything looks good!
Had tested on local Python test as well as on Lambda through Serverless and manual X-Ray invocation. |
Issue:
#156
In November of last year, AWS Lambda included official support for Python3.7 on Lambda, however, this project is not being tested using Python3.7.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.