-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github source and buildspec extraction to generate-pipeline #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General change looks fine to me. Could you elaborate on the benefits of defining the buildspec.yml
outside of the cloudformation template? Is it so you can update the CodeBuild job out of band and not have to do an entire CloudFormation deploy?
@kyleknap Yep exactly. It means that the people that have access to the source repo can now control how the codebuild process happens (vs. whoever manages the cfn template, which could be either separate teams or at least separate roles). I'll update the help message with this. |
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 94.94% 94.96% +0.02%
==========================================
Files 18 18
Lines 3203 3236 +33
Branches 417 421 +4
==========================================
+ Hits 3041 3073 +32
Misses 110 110
- Partials 52 53 +1
Continue to review full report at Codecov.
|
@kyleknap ready to look at again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. 🚢
This PR adds two options to the
generate-pipeline
command:--source github
. CFN template params are injected that require you to specify the owner and repo name when this option is provided.