Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github source and buildspec extraction to generate-pipeline #619

Merged
merged 3 commits into from
Nov 28, 2017

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Nov 25, 2017

This PR adds two options to the generate-pipeline command:

  • The ability to specify a github source via --source github. CFN template params are injected that require you to specify the owner and repo name when this option is provided.
  • The ability to write the CodeBuild buildspec file to a separate file. The default behavior is to include the contents as part of the cloudformation template.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General change looks fine to me. Could you elaborate on the benefits of defining the buildspec.yml outside of the cloudformation template? Is it so you can update the CodeBuild job out of band and not have to do an entire CloudFormation deploy?

@jamesls
Copy link
Member Author

jamesls commented Nov 28, 2017

@kyleknap Yep exactly. It means that the people that have access to the source repo can now control how the codebuild process happens (vs. whoever manages the cfn template, which could be either separate teams or at least separate roles). I'll update the help message with this.

@codecov-io
Copy link

codecov-io commented Nov 28, 2017

Codecov Report

Merging #619 into master will increase coverage by 0.02%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   94.94%   94.96%   +0.02%     
==========================================
  Files          18       18              
  Lines        3203     3236      +33     
  Branches      417      421       +4     
==========================================
+ Hits         3041     3073      +32     
  Misses        110      110              
- Partials       52       53       +1
Impacted Files Coverage Δ
chalice/cli/__init__.py 84.84% <100%> (+0.55%) ⬆️
chalice/pipeline.py 99.1% <97.5%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777428b...e39f96e. Read the comment docs.

@jamesls
Copy link
Member Author

jamesls commented Nov 28, 2017

@kyleknap ready to look at again.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. 🚢

@jamesls jamesls merged commit e39f96e into aws:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants