New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud watch events support #1126
Conversation
728b169
to
aad5cb1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
+ Coverage 95.98% 96.03% +0.05%
==========================================
Files 28 28
Lines 5176 5218 +42
Branches 658 665 +7
==========================================
+ Hits 4968 5011 +43
+ Misses 135 134 -1
Partials 73 73
Continue to review full report at Codecov.
|
202ff5b
to
87080f0
Compare
f08c425
to
c0b2edc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I still need to pull it down and try it out. Otherwise had some comments and suggestions. I think this will be really useful. Also we will probably need to do some rebasing to fix some conflicts.
Other thing I forgot... It would be good to add a changelog entry for this. You can add it under a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out and it worked well. I just had a couple more bits of feedback on the documentation after trying to use it to test out the feature
e8f03e7
to
725577f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Just had one small comment. Otherwise, I say we rebase off of master, add a changelog entry, and we can get this one merged too.
e720688
to
99dc613
Compare
rebased and added changelog and terraform packaging support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good. Just one a little picky comment: I noticed in the updated docs and in the code, CloudWatch is being spelled out as two words. Could we update it to make it one word (i.e. CloudWatch instead of CloudWatch in the docs and cloudwatch
instead of cloud_watch
in the code) to make it consistent with the official service branding and how it is exposed in boto3
? Otherwise, it should be good to merge.
wrt to cloudwatch, updated docs and code to reflect the product marketing name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Issue #1124
Support subscribing functions to cloud watch events.
with this pr the intent is that you can now subscribe to any of the dozen of event types that are sent through cloud watch events https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html
Example usage, in this case subscribing to ec2 instance state change notifications