Initial support for multi file apps #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's been several approaches proposed: 1. Support either 'app.py' *or* an ``app/`` directory. 2. Recursively find all python modules/packages (similar to what ``find_packages(.)`` does. 3. Have some type of manifest file that includes/excludes files. 4. Include a hard coded directory if it exists. This commit implements option 4, which I think has a good balance of control vs. ease of use: * If you want something included in the deployment package, put it in this directory. This works whether it's a python file or not. * If you don't something included in your deployment package, don't include it in ``chalicelib/``.
There's no reason to be using exec, and in fact breaks a few edge cases, notably the absense of `__file__`, which is more relevent given multi file app support.
The root cause is that sphinx replaces docutils directives with its own version, but doc8 doesn't know about sphinx directives. I think the better long term fix is going to be either use sphinx directly to verify docs, or to load the sphinx directives in doc8. Either way, I don't think this should be a hard bocker.
|
Docs/tests updated. I haven't any feedback on this PR nor on the original issue, so let's try this approach out for now. I imagine we may need to iterate on this, so I'd like to get this initial version available for people to try out. |
|
I don't see any info on this in the README |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been several approaches proposed:
app/directory.find_packages(.)does.This commit implements option 4, which I think has a good balance
of control vs. ease of use:
in this directory. This works whether it's a python file or not.
include it in
chalicelib/.cc @kyleknap @JordonPhillips