python 3.11 support #2063
python 3.11 support #2063
Conversation
| @@ -498,7 +499,8 @@ class DependencyBuilder(object): | |||
| 'cp36m': (2, 17), | |||
| 'cp37m': (2, 17), | |||
| 'cp38': (2, 26), | |||
| 'cp310': (2, 26) | |||
| 'cp310': (2, 26), | |||
| 'cp311': (2, 26), | |||
There was a problem hiding this comment.
$ docker run -it --entrypoint "ldd" public.ecr.aws/lambda/python:3.11 --version
ldd (GNU libc) 2.26
| elif (major, minor) <= (3, 9): | ||
| return 'python3.9' | ||
| return 'python3.10' | ||
| elif (major, minor) <= (3, 10): |
There was a problem hiding this comment.
Originally I just added an additional branch, but pylint did not like having that many return statements.
| @@ -271,15 +271,15 @@ Integrating with AWS Lambda Powertools | |||
| -------------------------------------- | |||
|
|
|||
| `AWS Lambda Powertools | |||
| <https://awslabs.github.io/aws-lambda-powertools-python/latest/>`__ is a suite of | |||
| <https://docs.powertools.aws.dev/lambda/python/latest/>`__ is a suite of | |||
There was a problem hiding this comment.
the prcheck link checker complained (failed) about these powertools links.
| @@ -45,7 +45,7 @@ | |||
| ], | |||
| }, | |||
| 'numpy': { | |||
| 'version': '1.21.6', | |||
| 'version': '1.23.3', | |||
There was a problem hiding this comment.
had a similar issue to last time where I had to bump these slightly to get a version that included 3.11.
| @@ -151,16 +151,13 @@ def lambda_python_version(self) -> str: | |||
| if major == 2: | |||
| return 'python2.7' | |||
| # Python 3 for backwards compatibility needs to select python3.6 | |||
| # for python versions 3.0-3.6. 3.7 and higher will use python3.7. | |||
| # for python versions 3.0-3.6. 3.7-3.10 will use their version. | |||
| # 3.11 and higher will use 3.11 | |||
| elif (major, minor) <= (3, 6): | |||
| return 'python3.6' | |||
There was a problem hiding this comment.
@jamesls I was noticing python 3.6 appears no longer supported: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Wasn't sure about changing this to force 3.7 as minimum? Maybe removing 3.6 would be better as a separate PR if it's wanted?...
|
This should be merged, is really important that chalice doesn't lag behind so much |
|
@jamesls Do you have any time soon to take a look at this? |
Agreed. It is important to merge this or provide feedback. |
|
Hi @jamesls I just wanted to check in to see if there's any changes I can make to make this PR easier to merge or if you have any feedback, I'm happy to make it. I know you're busy, so, no worries if you're also not ready to take a look at this. Thanks, and thanks again for your work on chalice! |
|
@jamesls Any word on merging this so Python 3.11 is supported? |
|
Can someone pls comment if this PR is merged? |
|
Looking forward for this! 🙌 |
|
Can't wait to have this PR merged 🙏🏼 |
|
Seems very promising, huge update, I understand it takes time to review :D |
|
Taking a look now. |
|
Looks great, thanks for the pull request! |
PR aws#2063 * python_3.11: Add changelog entry for python3.11 bump versions for 3.11 update links to powertools reduce number of returns initial pass at 3.11
|
Thanks @jamesls , I really appreciate your work on chalice! It's been really great to use! |
Issue #, if available: #2053
Description of changes:
Python 3.11 support
https://aws.amazon.com/blogs/compute/python-3-11-runtime-now-available-in-aws-lambda/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.