Can't use number parameters in addon templates and pass them to integer fields with !Ref

[Envek]

If I specify parameter of type Number in addon template and use it with !Ref in a field that requires integer, copilot deploy will fail:

: json: cannot unmarshal string into Go struct field Template.Resources of type int

It is convenient to use parameters to DRY values in templates and keep them app configuration in sync with infrastructure:

Parameters:
  MinPort:
    Type: Number
    Default: 40000
  MaxPort:
    Type: Number
    Default: 49999

Resources:
  EnvironmentSecurityGroupIngressTCPWebRTC:
    Type: AWS::EC2::SecurityGroupIngress
    Properties:
      Description: Ingress TCP for WebRTC media streams
      GroupId:
        Fn::ImportValue:
          !Sub "${App}-${Env}-EnvironmentSecurityGroup"
      IpProtocol: tcp
      CidrIp: '0.0.0.0/0'
      FromPort: !Ref MinPort # <- Problem is here
      ToPort:   !Ref MaxPort # <- Problem is here

Outputs:
  MediasoupMinPort:
    Value: !Ref MinPort
  MediasoupMaxPort:
    Value: !Ref MaxPort

But if I execute this template with aws cloudformation create-stack it will be created successfully.

Related issues (as copilot use goformation): awslabs/goformation#252 and awslabs/goformation#304.

Full example here

copilot/app/addons/ingress-rules.yml:

Parameters:
  App:
    Type: String
    Description: Your application's name.
  Env:
    Type: String
    Description: The environment name your service, job, or workflow is being deployed to.
  MediasoupMinPort:
    Type: Number
    Default: 40000
    Description: "Start of the port range used to receive WebRTC connections with media streams from peers."
    MinValue: 1024
    MaxValue: 65535
  MediasoupMaxPort:
    Type: Number
    Default: 49999
    Description: "End of the port range used to receive WebRTC connections with media streams from peers."
    MinValue: 1024
    MaxValue: 65535

Resources:
  EnvironmentSecurityGroupIngressTCPWebRTC:
    Type: AWS::EC2::SecurityGroupIngress
    Properties:
      Description: Ingress TCP for WebRTC media streams
      GroupId:
        Fn::ImportValue:
          !Sub "${App}-${Env}-EnvironmentSecurityGroup"
      IpProtocol: tcp
      CidrIp: '0.0.0.0/0'
      FromPort: !Ref MediasoupMinPort
      ToPort:   !Ref MediasoupMaxPort

  EnvironmentSecurityGroupIngressUDPWebRTC:
    Type: AWS::EC2::SecurityGroupIngress
    Properties:
      Description: Ingress UDP for WebRTC media streams
      GroupId:
        Fn::ImportValue:
          !Sub "${App}-${Env}-EnvironmentSecurityGroup"
      IpProtocol: udp
      CidrIp: '0.0.0.0/0'
      FromPort: !Ref MediasoupMinPort
      ToPort:   !Ref MediasoupMaxPort

Outputs:
  MediasoupMinPort:
    Description: "Start of the port range used to receive WebRTC connections with media streams from peers."
    Value: !Ref MediasoupMinPort
  MediasoupMaxPort:
    Description: "End of the port range used to receive WebRTC connections with media streams from peers."
    Value: !Ref MediasoupMaxPort

How to run it via CloudFormation:

app=panel-discussions
env=test
aws cloudformation create-stack --stack-name $app-$env-vpc-subnets --template-body file://copilot/app/addons/ingress-rules.yml --parameters ParameterKey=App,ParameterValue=$app ParameterKey=Env,ParameterValue=$env --tags Key=copilot-application,Value=$app Key=copilot-environment,Value=$env

[efekarakus]

Heya @Envek !

Like you pointed out this is an underlying issue with the goformation library that we use :( we have a backlog item to write our own custom logic to avoid these errors.

Sorry about the inconvenience!

[efekarakus]

Related #1402

[efekarakus]

This was released just now in v1.1.0: https://github.com/aws/copilot-cli/releases/tag/v1.1.0!