Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudFormation: Add tags for environments #190

Closed
kohidave opened this issue Oct 10, 2019 · 1 comment · Fixed by #195
Closed

CloudFormation: Add tags for environments #190

kohidave opened this issue Oct 10, 2019 · 1 comment · Fixed by #195
Assignees
@SoManyHs
Labels
good first issue Issues for newcomers.
Milestone
2. Deploy

Comments

@kohidave
Copy link
Contributor

kohidave commented Oct 10, 2019 •
edited by SoManyHs
Loading

In CreateChangeSet, we should provide tags. This will let us transitively tag all our created resources.

The tags for environment should be:

ecs-project:{project name}, ecs-env:{env-name}

CF Documentation Ref
@kohidave kohidave added this to the 2. Deploy milestone Oct 10, 2019
@kohidave kohidave added the good first issue Issues for newcomers. label Oct 10, 2019
@kohidave
Copy link
Contributor Author

This will resolve #54

@SoManyHs SoManyHs self-assigned this Oct 11, 2019
SoManyHs referenced this issue in SoManyHs/copilot-cli Oct 11, 2019
@SoManyHs
Add tags to environment
53396b6 
Fixes #190
@SoManyHs SoManyHs mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

Labels
good first issue Issues for newcomers.
Projects
None yet
Milestone
2. Deploy
Development

Successfully merging a pull request may close this issue.

Add tags to environment SoManyHs/copilot-cli
2 participants
@kohidave @SoManyHs