Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose health check path in manifest #597

Closed
kohidave opened this issue Jan 10, 2020 · 3 comments · Fixed by #739
Closed

Expose health check path in manifest #597

kohidave opened this issue Jan 10, 2020 · 3 comments · Fixed by #739
Assignees
@SoManyHs
Labels
area/manifest Issues about infrastructure-as-code templates. type/enhancement Issues that are improvements for existing features.
Projects
Sprint 🏃‍♀️

Comments

@kohidave
Copy link
Contributor

Right now, the health check is hardcoded to / - we should let folks specify that from the manifest.
@kohidave kohidave added type/enhancement Issues that are improvements for existing features. area/manifest Issues about infrastructure-as-code templates. labels Jan 10, 2020
@efekarakus efekarakus added this to Backlog in Sprint 🏃‍♀️ via automation Jan 27, 2020
@iamhopaul123 iamhopaul123 moved this from Backlog to In progress in Sprint 🏃‍♀️ Feb 10, 2020
@SoManyHs
Copy link
Contributor

Do we want customers to be able to pass this in through a flag on the app init command, or simply expose the field in the manifest itself?

@SoManyHs
Copy link
Contributor

Note: this will just be a top-level field in the app manifest

@SoManyHs
Copy link
Contributor

Will probably keep default to just be /

SoManyHs added a commit to SoManyHs/copilot-cli that referenced this issue Mar 13, 2020
@SoManyHs
feat: add healthcheck path to app manifest
a8c7a54 
Closes aws#597.
@SoManyHs SoManyHs mentioned this issue Mar 13, 2020
Merged
@SoManyHs SoManyHs moved this from In progress to In review in Sprint 🏃‍♀️ Mar 13, 2020
Sprint 🏃‍♀️ automation moved this from In review to Pending release Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoManyHs SoManyHs

Labels
area/manifest Issues about infrastructure-as-code templates. type/enhancement Issues that are improvements for existing features.
Projects
Sprint 🏃‍♀️
  
Pending release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add healthcheck path to app manifest SoManyHs/copilot-cli
3 participants
@kohidave @SoManyHs @iamhopaul123