-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manifest): add HTTP Health Check hidden fields #1592
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b09f875
wip
huanjani 3647310
chore: get template building properly; start tests
huanjani f72c8ba
chore: finish unit tests
huanjani 2af5287
Merge remote-tracking branch 'archer/mainline' into healthcheck
huanjani 9017edf
fix: uc HTTP in template yaml
huanjani 945c67c
fix: reorder fields
huanjani dba23a2
fix: refactor to enable ArgsOrString, change ints to duration, etc.
huanjani fa2bfeb
fix: remove unused method
huanjani 3876af8
fix: remove 's' for seconds from template
huanjani ebcdb9c
Merge branch 'mainline' into healthcheck
huanjani 6f0d31c
fix: default path (/) in manifest so not nil
huanjani ccb5a5a
chore: allow camel case and snake case for target container yaml field
huanjani 89969dd
Merge branch 'mainline' into healthcheck
huanjani da4df77
Merge branch 'mainline' into healthcheck
huanjani File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's remove words like cannot from the error message unless it's in the
cli
pkg (the root pkg)https://github.com/uber-go/guide/blob/master/style.md#error-wrapping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine to keep
can't
in this scenario since it is already the root error instead of wrapping the other error. Agree if we are wrapping error we want to avoid piling up likefailed to get health check: can't unmarshal health check
. And instead we wantget health check: can't unmarshal health check
. What do you all think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More the opposite,
cannot get health check: unmarshal health check
. Where the root error that wraps others can use "cannot" to make it more human friendly but "library" pkgs shouldn't put cannot in their error messagesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But according to https://github.com/uber-go/guide/blob/master/style.md#error-wrapping, isn't
cannot get health check: unmarshal health check
a bad example?