fix(buildspec): addons template url uses dot region #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
changed the title
efekarakus
changed the title
efekarakus
approved these changes
Nov 17, 2020
iamhopaul123
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Thank you so much for fixing this! Could you update your commit with the conventional style?
For example fix: addons template url in buildspec
lukeledet
force-pushed
the
fix-addon-s3-url
branch
from
2d48904
to
3e84078
Compare
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
<!-- Provide summary of changes --> I saw this error in cloudformation when deploying a service via a pipeline: `"TemplateURL must reference a valid S3 object to which you have access."` Updating my buildspec with this change fixed the issue. [S3 docs](https://docs.aws.amazon.com/AmazonS3/latest/dev/VirtualHosting.html) show this is a legacy URL that doesn't work for all regions. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this error in cloudformation when deploying a service via a pipeline:
"TemplateURL must reference a valid S3 object to which you have access."Updating my buildspec with this change fixed the issue. S3 docs show this is a legacy URL that doesn't work for all regions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.