fix(manifest): preserve default values on environment overrides for jobs #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efekarakus
force-pushed
the
fix-issues-2043
branch
from
bbf06f4
to
cdf92d3
Compare
bvtujo
reviewed
Mar 11, 2021
Comment on lines
+96
to
+113
| if props.Name != "" { | ||
| job.Name = aws.String(props.Name) | ||
| } | ||
| if props.Dockerfile != "" { | ||
| job.ScheduledJobConfig.ImageConfig.Build.BuildArgs.Dockerfile = aws.String(props.Dockerfile) | ||
| } | ||
| if props.Image != "" { | ||
| job.ScheduledJobConfig.ImageConfig.Location = aws.String(props.Image) | ||
| } | ||
| if props.Schedule != "" { | ||
| job.On.Schedule = aws.String(props.Schedule) | ||
| } | ||
| if props.Retries != 0 { | ||
| job.Retries = aws.Int(props.Retries) | ||
| } | ||
| if props.Timeout != "" { | ||
| job.Timeout = aws.String(props.Timeout) | ||
| } |
There was a problem hiding this comment.
o_O thank you so much for cleaning up this craziness
bvtujo
approved these changes
Mar 11, 2021
huanjani
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2043, fixes #1736
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.