feat: add svc exec and task exec #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-30T22:14:28.000Z Address feedback commit c09bbba6bd10d646417510d998451a1f2e141bbe Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-23T23:23:21.000Z chore: add boilerplate for copilot exec cr https://code.amazon.com/reviews/CR-39357784 commit 46a0f2bea06e6436e1ecf333546f5a3fa50411e2 Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-23T20:14:22.000Z chore: add custom aws-sdk-go for ECS cr https://code.amazon.com/reviews/CR-39348057 commit 25be354 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2020-11-30T17:07:40.000Z chore: Bump github.com/briandowns/spinner from 1.11.1 to 1.12.0 (aws#1729) Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.11.1 to 1.12.0. - [Release notes](https://github.com/briandowns/spinner/releases) - [Commits](briandowns/spinner@v1.11.1...v1.12) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> commit ef735c9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2020-11-30T17:02:37.000Z chore: Bump github.com/aws/aws-sdk-go from 1.35.33 to 1.35.35 (aws#1730) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.33 to 1.35.35. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.33...v1.35.35) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ce836bd Author: Janice Huang <60631893+huanjani@users.noreply.github.com> Date: 2020-11-24T22:43:38.000Z chore(cli): make the dashes under column headings consistent (aws#1705) Wherever command output is in tabular format, this brings consistency to our formatting-- dashes (same length as heading, not longest element) below the headings. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. commit 6128e9c Author: Janice Huang <60631893+huanjani@users.noreply.github.com> Date: 2020-11-24T20:22:47.000Z feat(cli): display secrets as subcategory in `svc_show` (aws#1704) This change displays secrets as a separate category (not within "Variables") in `svc show`. If the secret value comes from Parameter Store, it is preceded by `parameter/`. Otherwise, if it comes from Secrets Manager, it is displayed as an ARN. Addresses aws#720 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. commit 42567bf Author: Efe Karakus <karakuse@amazon.com> Date: 2020-11-23T21:39:32.000Z docs(README): remove preview program description (aws#1722) _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
iamhopaul123
added
the
do-not-merge
iamhopaul123
force-pushed
the
internalMainline
branch
2 times, most recently
from
edfc833
to
6ea752a
Compare
iamhopaul123
force-pushed
the
internalMainline
branch
from
6ea752a
to
2876274
Compare
iamhopaul123
force-pushed
the
internalMainline
branch
from
6a4e013
to
1cf90c5
Compare
efekarakus
approved these changes
Mar 15, 2021
huanjani
approved these changes
Mar 15, 2021
iamhopaul123
removed
the
do-not-merge
thrau
pushed a commit
to localstack/copilot-cli-local
that referenced
this pull request
Dec 9, 2022
* chore: add custom aws-sdk-go for ECS cr https://code.amazon.com/reviews/CR-39348057 * commit e19046ca2668f00fdbd4d328d86ef2b9e576b9d5 Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-30T22:14:28.000Z Address feedback commit c09bbba6bd10d646417510d998451a1f2e141bbe Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-23T23:23:21.000Z chore: add boilerplate for copilot exec cr https://code.amazon.com/reviews/CR-39357784 commit 46a0f2bea06e6436e1ecf333546f5a3fa50411e2 Author: penghaoh <penghaoh@amazon.com> Date: 2020-11-23T20:14:22.000Z chore: add custom aws-sdk-go for ECS cr https://code.amazon.com/reviews/CR-39348057 commit 25be354 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2020-11-30T17:07:40.000Z chore: Bump github.com/briandowns/spinner from 1.11.1 to 1.12.0 (aws#1729) Bumps [github.com/briandowns/spinner](https://github.com/briandowns/spinner) from 1.11.1 to 1.12.0. - [Release notes](https://github.com/briandowns/spinner/releases) - [Commits](briandowns/spinner@v1.11.1...v1.12) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> commit ef735c9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: 2020-11-30T17:02:37.000Z chore: Bump github.com/aws/aws-sdk-go from 1.35.33 to 1.35.35 (aws#1730) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.35.33 to 1.35.35. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.35.33...v1.35.35) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ce836bd Author: Janice Huang <60631893+huanjani@users.noreply.github.com> Date: 2020-11-24T22:43:38.000Z chore(cli): make the dashes under column headings consistent (aws#1705) Wherever command output is in tabular format, this brings consistency to our formatting-- dashes (same length as heading, not longest element) below the headings. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. commit 6128e9c Author: Janice Huang <60631893+huanjani@users.noreply.github.com> Date: 2020-11-24T20:22:47.000Z feat(cli): display secrets as subcategory in `svc_show` (aws#1704) This change displays secrets as a separate category (not within "Variables") in `svc show`. If the secret value comes from Parameter Store, it is preceded by `parameter/`. Otherwise, if it comes from Secrets Manager, it is displayed as an ARN. Addresses aws#720 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. commit 42567bf Author: Efe Karakus <karakuse@amazon.com> Date: 2020-11-23T21:39:32.000Z docs(README): remove preview program description (aws#1722) _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ * chore(cli): boilerplate for svc/job/task exec cr https://code.amazon.com/reviews/CR-39984997 * Address feedback and add --cluster flag to task exec * chore(cli): add validate and ask for svc exec cr https://code.amazon.com/reviews/CR-40079015 * chore(cli): implement svc exec Execute() cr https://code.amazon.com/reviews/CR-40177002 * Address comment * chore(ecs): implement ExecuteCommand API cr https://code.amazon.com/reviews/CR-40448327 * Remove log in ecs pkg * Add log prompting users to delete the orphan session * Remove ErrExecuteCommand * chore(exec): implement StartSession for OS cr https://code.amazon.com/reviews/CR-40615982 * Use http/Get to download the binary instead of curl to local * Move ssm plugin validate to cli pkg * chore(ecs): remove terminate session call in ExecuteCommand cr https://code.amazon.com/reviews/CR-40863766 * chore(exec): add plugin management for non macos platforms cr https://code.amazon.com/reviews/CR-40966835 * chore: use gamma endpoint for ECS and RGTA client * Avoid outputting when validating ssm plugin on windows * Update frontend model * Address feedback * Address feedback * chore(exec): apply interactive run to start session cr https://code.amazon.com/reviews/CR-41395554 * chore(manifest): add exec field to the manifest cr https://code.amazon.com/reviews/CR-41475925 * chore(stack): update stack pkg and CFN template for services and environment cr https://code.amazon.com/reviews/CR-41546916 * Address iyerv@ feedback * Rename exec to executeCommand and use go template instead of CFN param * chore(cli): remove interactive flag and job exec cr https://code.amazon.com/reviews/CR-41851301 * chore(cli): add task exec validate cr https://code.amazon.com/reviews/CR-41860865 * chore(cli): add ssm plugin validation for task exec cr https://code.amazon.com/reviews/CR-41862462 * chore(selector): add running tasks selector (aws#1792) <!-- Provide summary of changes --> Add `RunningTask()` to `selector` pkg, allowing to select a running copilot task. <!-- Issue number, if available. E.g. "Fixes aws#31", "Addresses aws#42, 77" --> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. * Resolve merging conflict cr https://code.amazon.com/reviews/CR-41929264 * chore(cli): add Ask() for task exec cr https://code.amazon.com/reviews/CR-41994838 * Fix prompt text cr https://code.amazon.com/reviews/CR-42292095 * Address feedback * chore(templates): add resource comments to v1.2.0 env template * chore(cli): implement Execute() for task exec cr https://code.amazon.com/reviews/CR-42377497 * chore: enable execute-command for task run cr https://code.amazon.com/reviews/CR-42467741 * chore(cli): remove exec related unused code cr https://code.amazon.com/reviews/CR-42531908 * docs: add docs for svc/task exec cr https://code.amazon.com/reviews/CR-42539124 * Address feedback * chore(cli): task exec should be able to use --default in workspace cr https://code.amazon.com/reviews/CR-43124690 * chore(env): update v1.2.0 env template cr https://code.amazon.com/reviews/CR-43574909 * chore(doc): add info for svc-exec cr https://code.amazon.com/reviews/CR-43631507 * chore: fix template bugs and remove gamma endpoint usage cr https://code.amazon.com/reviews/CR-43826647 * Address feedback * Update the doc * chore(task): add default task role for exec cr https://code.amazon.com/reviews/CR-43838665 * Update task exec doc * chore(exec): enable svc exec by default cr https://code.amazon.com/reviews/CR-43849472 * Change execute_command default to false * chore(exec): task exec only lists one-off task cr https://code.amazon.com/reviews/CR-43918751 * chore: fix ubuntu ssm plugin install and exec doc cr https://code.amazon.com/reviews/CR-44013235 * Address feedback * chore(manifest): rename execute_command to exec cr https://code.amazon.com/reviews/CR-44072460 * chore(exec): UI changes and test fixes cr https://code.amazon.com/reviews/CR-44358240 * chore: fix unit test cr https://code.amazon.com/reviews/CR-44369866 * chore(template): switch AMZN::ECS::Service to AWS::ECS::Service cr https://code.amazon.com/reviews/CR-44443109 * chore(exec): add flag to skip confirmation for SSM plugin * chore(exec): task exec task family name should be prefixed * chore(e2e): add exec suite cr https://code.amazon.com/reviews/CR-44552067 * Address feedback * Add to the e2e buildspec * chore(doc): add exec video cr https://code.amazon.com/reviews/CR-47049800 * Disable exec e2e test * Remove new-sdk-go and update aws ecs sdk go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
copilot svc execandcopilot task execcommandsWe'll remove the "new-sdk-go" and take off "do-not-merge" tag when aws-sdk-go releases exec feature next Monday.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.