Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): add fish completion #2517

Merged
merged 11 commits into from
Jul 8, 2021
Merged

feat(cmd): add fish completion #2517

merged 11 commits into from
Jul 8, 2021

Conversation

chenrui333
Copy link
Contributor

Add fish completion for the CLI

@chenrui333 chenrui333 requested a review from a team as a code owner June 25, 2021 01:29
@chenrui333 chenrui333 requested review from Lou1415926 and removed request for a team June 25, 2021 01:29
@chenrui333 chenrui333 changed the title cmd: add fish completion feat(cmd): add fish completion Jun 25, 2021
@chenrui333 chenrui333 marked this pull request as draft June 25, 2021 01:50
@chenrui333 chenrui333 marked this pull request as ready for review June 25, 2021 02:19
@chenrui333
fix: revert mock_status change
0e62b29 
Signed-off-by: Rui Chen <rui@chenrui.dev>
efekarakus
efekarakus reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@efekarakus efekarakus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay thank you! It looks good just a small sentence fix 🙏

internal/pkg/cli/completion.go Outdated Show resolved Hide resolved
Lou1415926
Lou1415926 reviewed Jun 25, 2021
View reviewed changes
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you so much for helping 🙏🏼 🥳.

I just have one small nits about the wording, (i.e. "bash", "zsh" or "fish" instead of "bash" or "zsh" or "fish" for smother reading experience). All of review my comments are for the same nits, just different places.

internal/pkg/cli/completion.go Outdated Show resolved Hide resolved
internal/pkg/cli/completion.go Outdated Show resolved Hide resolved
internal/pkg/cli/completion.go Outdated Show resolved Hide resolved
internal/pkg/cli/completion_test.go Outdated Show resolved Hide resolved
site/content/docs/commands/completion.en.md Outdated Show resolved Hide resolved
@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jun 29, 2021
@efekarakus efekarakus removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 1, 2021
@iamhopaul123 iamhopaul123 added do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. and removed do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. labels Jul 8, 2021
@chenrui333
Copy link
Contributor Author

Thanks for fixing the wording issues.

@chenrui333
Copy link
Contributor Author

I think the PR is ready to be merged. 🎉

Lou1415926
Lou1415926 approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@Lou1415926 Lou1415926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesomee!! Thank you so much for updating this!

@Lou1415926 Lou1415926 added do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. and removed do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. labels Jul 8, 2021
@mergify mergify bot merged commit 42528f4 into aws:mainline Jul 8, 2021
Sprint 🏃‍♀️ automation moved this from In review to Pending release Jul 8, 2021
@chenrui333 chenrui333 deleted the add-fish-completion branch September 1, 2021 05:14
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
@chenrui333 @thrau
feat(cmd): add fish completion (aws#2517)
33108d2 
Add fish completion for the CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efekarakus efekarakus efekarakus approved these changes

@Lou1415926 Lou1415926 Lou1415926 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenrui333 @efekarakus @Lou1415926 @iamhopaul123