Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check bucket owner permission #122

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

saikiranakula-amzn
Copy link
Collaborator

@saikiranakula-amzn saikiranakula-amzn commented Apr 9, 2024

Issue #, if available:

Description of changes:
Check bucket owner permission before retrieving credentialspec
Testing done:

[ec2-user@EC2AMAZ-Ll40tS tests]$ sudo ./gmsa_test_client --create_kerberos_tickets_arn arn:aws:s3:::gmsacredspec/gmsa-cred-spec.json#3456/test xxxx xxxx xxxx us-west-2
krb tickets will get created
created ticket for gMSA /var/credentials-fetcher/krbdir/3456/test
Client received output for add kerberos arn lease: 3456
provide a valid arg, for help use -h or --help

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have updated any necessary documentation, including READMEs and comments (where appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jamolina jamolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@saikiranakula-amzn saikiranakula-amzn merged commit 39aeb63 into mainline Apr 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants