Wip/wasm #36
Closed
Wip/wasm #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2020
Closed
|
Looks good to me |
Urhengulas
approved these changes
Jul 13, 2020
|
And a small other idea would be to use cfg-if for the conditional compilation. Could make it bit cleaner. |
|
Hello @fabiosky 👋 When do you think this PR will land? I'd like to commit it to our main branch and would prefer a cargo release over a git-dependency. Are there any blockers I could help with? |
|
Hi @Urhengulas , I rebased the code above on master, |
|
Here's the new release that comes with wasm32 support: |
|
Published on crates too: |
|
This was merged on master. |
|
Thank you very much for your work @fabiosky!! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#23
#35
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.