Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build,test] Disable dedicated telemetry tests and tags #1045

Merged
merged 2 commits into from
Apr 21, 2021
Merged

[build,test] Disable dedicated telemetry tests and tags #1045

merged 2 commits into from
Apr 21, 2021

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Apr 20, 2021 •
edited

Issue #, if available:

PR Checklist

  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Reviewer Checklist

  • For reviewer, before merging, please cross-check:
  • I've verified the code change on the config file mentioned above has already been reverted

Description:

  • Modify deep_learning_container.py, and skip all tests
  • Keep unit tests for feature accessibility enabled.

Tests run:

DLC image/dockerfile:

Additional context:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saimidu saimidu self-assigned this Apr 20, 2021
@saimidu saimidu merged commit f08ff35 into aws:master Apr 21, 2021
@saimidu saimidu deleted the remove_tagging_telemetry branch April 21, 2021 18:03
saimidu added a commit to saimidu/deep-learning-containers that referenced this pull request Apr 22, 2021
@saimidu
Revert "[build,test] Disable dedicated telemetry tests and tags (aws#…
42bd860 
…1045)"

This reverts commit f08ff35.
@saimidu saimidu mentioned this pull request Apr 22, 2021
Merged
6 tasks
jeet4320 added a commit to jeet4320/deep-learning-containers that referenced this pull request Apr 23, 2021
@jeet4320
Merge remote-tracking branch 'aws/master' into efa-pt-tf2
1dc65b5 
* aws/master:
  [doc] Minor corrections on available_images (aws#1061)
  [huggingface_pytorch] upgrade PyTorch to 1.7.1 (aws#1025)
  Fix for hf canary tests (aws#1057)
  [test][huggingface_tensorflow, huggingface_pytorch] SM local and remote tests (aws#1021)
  hf transformer version update (aws#1060)
  [build] update EIA buildspec and upgrade ruamel_yaml package (aws#1051)
  bump transformer version (aws#1056)
  Including hf images into canary tests (aws#1050)
  fix tf1 neuron buildspec (aws#1048)
  [build,test] Disable dedicated telemetry tests and tags (aws#1045)
  [test][sagemaker] Execute SM local tests in parallel (aws#1027)
jeet4320 added a commit to jeet4320/deep-learning-containers that referenced this pull request Apr 27, 2021
@jeet4320
Merge remote-tracking branch 'aws/master'
37123ad 
* aws/master:
  [doc] Minor corrections on available_images (aws#1061)
  [huggingface_pytorch] upgrade PyTorch to 1.7.1 (aws#1025)
  Fix for hf canary tests (aws#1057)
  [test][huggingface_tensorflow, huggingface_pytorch] SM local and remote tests (aws#1021)
  hf transformer version update (aws#1060)
  [build] update EIA buildspec and upgrade ruamel_yaml package (aws#1051)
  bump transformer version (aws#1056)
  Including hf images into canary tests (aws#1050)
  fix tf1 neuron buildspec (aws#1048)
  [build,test] Disable dedicated telemetry tests and tags (aws#1045)
  [test][sagemaker] Execute SM local tests in parallel (aws#1027)
  Temporaru disabling sagemaker tests for HF containers. (aws#1042)
  Add automatic yes to prompts for apt (aws#1043)
tejaschumbalkar added a commit that referenced this pull request Apr 27, 2021
@saimidu @tejaschumbalkar
Revert "[build,test] Disable dedicated telemetry tests and tags (#1045)…
cd769bc 
…" (#1055)

This reverts commit f08ff35.

Co-authored-by: Tejas Chumbalkar <34728580+tejaschumbalkar@users.noreply.github.com>
jeet4320 added a commit to jeet4320/deep-learning-containers that referenced this pull request Apr 29, 2021
@jeet4320
Merge remote-tracking branch 'aws/master' into update-tf-2.3
cc20156 
* aws/master:
  [pytorch][release] Release pt1.6 Inference cpu, gpu and training cpu (aws#1074)
  [tensorflow, pytorch] [build] [test] [ec2, ecs, eks, sagemaker] Add EFA stack and tests (aws#1044)
  [pytorch][build][test] Update PT1.6.0 for pillow to 8.2.0 (aws#1071)
  Revert "[build,test] Disable dedicated telemetry tests and tags (aws#1045)" (aws#1055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejaschumbalkar tejaschumbalkar tejaschumbalkar approved these changes

Assignees

@saimidu saimidu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saimidu @tejaschumbalkar