[TensorFlow] TF2.11 EC2 release #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-deep-learning-containers-ci
bot
added
build
aws-deep-learning-containers-ci
bot
added
sanity
aws-deep-learning-containers-ci
bot
added
the
ec2
|
Please update PR description |
saimidu
reviewed
Nov 29, 2022
saimidu
reviewed
Nov 29, 2022
|
|
||
| ARG OPEN_MPI_PATH=/opt/amazon/openmpi | ||
| ARG EFA_PATH=/opt/amazon/efa | ||
| ARG EFA_VERSION=1.17.2 |
There was a problem hiding this comment.
Why 1.17? Could we get confirmation from other stakeholders that rely on the EFA installed within the TF DLC that this version works for them?
There was a problem hiding this comment.
We had agreed upon keeping EFA as is to mimic TF2.10. There has been no pushback on this EFA version
saimidu
reviewed
Nov 29, 2022
Comment on lines
+96
to
+103
| # The 'apt-get install' of nvinfer-runtime-trt-repo-ubuntu1804-5.0.2-ga-cuda10.0 | ||
| # adds a new list which contains libnvinfer library, so it needs another | ||
| # 'apt-get update' to retrieve that list before it can actually install the | ||
| # library. | ||
| # We don't install libnvinfer-dev since we don't need to build against TensorRT, | ||
| # and libnvinfer4 doesn't contain libnvinfer.a static library. | ||
| # nvinfer-runtime-trt-repo doesn't have a 1804-cuda10.1 version yet. see: | ||
| # https://developer.download.nvidia.cn/compute/machine-learning/repos/ubuntu1804/x86_64/ |
There was a problem hiding this comment.
Is this still applicable after having moved to TF 2.11 and CUDA 11.2?
There was a problem hiding this comment.
Is this still needed for TF2.11? If this is for CUDA 10?
There was a problem hiding this comment.
Just an avenue for further exploration. Not a blocker to merging this PR.
saimidu
reviewed
Nov 29, 2022
saimidu
reviewed
Nov 29, 2022
test/dlc_tests/ec2/tensorflow/training/test_tensorflow_training.py
Outdated
Show resolved
Hide resolved
saimidu
reviewed
Nov 29, 2022
saimidu
reviewed
Nov 29, 2022
saimidu
reviewed
Nov 29, 2022
tejaschumbalkar
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue #, if available:
Note: If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.
Description
This PR is to release EC2 TF2.11 Images for Training. This will not release SM as that is a separate Currency Release
PR Checklist
Benchmark Testing Checklist
dlc_developer_config.tomlin my PR branch by settingbenchmark_mode = trueBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.