Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGI 1.0.3 Release #3285

Closed
wants to merge 20 commits into from
Closed

TGI 1.0.3 Release #3285

wants to merge 20 commits into from

Conversation

amzn-choeric
Copy link
Contributor

GitHub Issue #, if available:

Note:

  • If merging this PR should also close the associated Issue, please also add that Issue # to the Linked Issues section on the right.

  • All PR's are checked weekly for staleness. This PR will be closed if not updated in 30 days.

Description

Modifying the release images for TGI 1.0.2 for preparation.

Tests run

NOTE: By default, docker builds are disabled. In order to build your container, please update dlc_developer_config.toml and specify the framework to build in "build_frameworks"

  • I have run builds/tests on commit for my changes.

NOTE: If you are creating a PR for a new framework version, please ensure success of the standard, rc, and efa sagemaker remote tests by updating the dlc_developer_config.toml file:

  • Revision A: sagemaker_remote_tests = "standard"
  • Revision B: sagemaker_remote_tests = "rc"
  • Revision C: sagemaker_remote_tests = "efa"

Additionally, please run the sagemaker local tests in at least one revision:

  • sagemaker_local_tests = true

Formatting

DLC image/dockerfile

Additional context

PR Checklist

  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron/graviton] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • If the PR changes affects SM test, I've modified dlc_developer_config.toml in my PR branch by setting sagemaker_tests = true and efa_tests = true
  • If this PR changes existing code, the change fully backward compatible with pre-existing code. (Non backward-compatible changes need special approval.)
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Pytest Marker Checklist

  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

EIA/NEURON/GRAVITON Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting ei_mode = true, neuron_mode = true or graviton_mode = true

Benchmark Testing Checklist

  • When creating a PR:
  • I've modified dlc_developer_config.toml in my PR branch by setting benchmark_mode = true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@amzn-choeric amzn-choeric requested review from a team as code owners August 28, 2023 18:23
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added the Size:XS Determines the size of the PR label Aug 28, 2023
@amzn-choeric amzn-choeric marked this pull request as draft August 29, 2023 14:51
@haixiw haixiw changed the title TGI 1.0.2 Release TGI 1.0.3 Release Sep 6, 2023
@ystarikovich
Copy link

ystarikovich commented Sep 6, 2023

@haixiw is there a plan to merge this PR in the near future? Is there a possibility of accessing the image before the official release? I was checking the image 763104351884.dkr.ecr.us-east-1.amazonaws.com/huggingface-pytorch-tgi-inference:2.0.1-tgi1.0.3-gpu-py39-cu118-ubuntu20.04 but the manifest is still unknown.

I that the PR - awslabs/llm-hosting-container#30 got already approved

@haixiw
Copy link
Contributor

haixiw commented Sep 7, 2023

@haixiw is there a plan to merge this PR in the near future? Is there a possibility of accessing the image before the official release? I was checking the image 763104351884.dkr.ecr.us-east-1.amazonaws.com/huggingface-pytorch-tgi-inference:2.0.1-tgi1.0.3-gpu-py39-cu118-ubuntu20.04 but the manifest is still unknown.

I that the PR - awslabs/llm-hosting-container#30 got already approved

Yeah we are gonna release this in a week or so. Accessing image before official image is not allowed by the process, But let me know if it's urgently needed Thanks

@ystarikovich
Copy link

@haixiw is there a plan to merge this PR in the near future? Is there a possibility of accessing the image before the official release? I was checking the image 763104351884.dkr.ecr.us-east-1.amazonaws.com/huggingface-pytorch-tgi-inference:2.0.1-tgi1.0.3-gpu-py39-cu118-ubuntu20.04 but the manifest is still unknown.
I that the PR - awslabs/llm-hosting-container#30 got already approved

Yeah we are gonna release this in a week or so. Accessing image before official image is not allowed by the process, But let me know if it's urgently needed Thanks

Would be great to have EAP. I created the AWS case as well for the same, but generally speaking this would be helpful to have earlier access. We found a workaround, but maybe we will hit again some limitations and will be forced to use TGI 1.0.3. So I will contact again.

@haixiw haixiw marked this pull request as ready for review September 8, 2023 22:26
arjkesh
arjkesh previously approved these changes Sep 11, 2023
dkey-amazon and others added 13 commits September 11, 2023 18:07
…3304)

* update torchserve to 0.8.2

* retry failed tests

* add allowlist for torch CVE

* Trigger Build

* trigger x86 tests

* set datetime_tag = true

* fix allowlists and run only sanity test

* fix testTorchdata and only run ec2 test

* revert testrunner.py and run whole ec2 test

* revert graviton buildspec and test config

---------

Co-authored-by: Sally Seok <sallyseo@amazon.com>
Co-authored-by: Tejas Chumbalkar <34728580+tejaschumbalkar@users.noreply.github.com>
… 0.8.2 (#3316)

* update torchserve to 0.8.2 and add allowlists

* revert test config

---------

Co-authored-by: Sally Seok <sallyseo@amazon.com>
Co-authored-by: arjkesh <33526713+arjkesh@users.noreply.github.com>
…for Neuron release 2.13.2 (#3314)

* Add Tensorflow inference images for release 2.13.2

* Fix file not updated and vulns

* Fix ignore_ids json

* Whitelist more scipy and grpcio vulns

* Whitelist grpcio

* Add collectives lib to neuronx image

* Revert develop config
Co-authored-by: Sally Seok <sallyseo@amazon.com>
@aws-deep-learning-containers-ci aws-deep-learning-containers-ci bot added build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR src Reflects file change in src folder tensorflow Reflects file change in tensorflow folder labels Sep 11, 2023
@haixiw haixiw marked this pull request as draft September 11, 2023 18:11
@haixiw haixiw closed this Sep 11, 2023
@haixiw
Copy link
Contributor

haixiw commented Sep 11, 2023

new PR:#3323

@amzn-choeric amzn-choeric deleted the tgi-1.0.2 branch November 14, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Reflects file change in build folder pytorch Reflects file change in pytorch folder Size:S Determines the size of the PR Size:XS Determines the size of the PR src Reflects file change in src folder tensorflow Reflects file change in tensorflow folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants