add CentOS 8 to mangle-shebangs.sh #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cappuccinuo
reviewed
Apr 17, 2020
README.md
Outdated
| @@ -132,7 +133,7 @@ or refer to the [documentation](https://docs.aws.amazon.com/efs/latest/ug/using- | |||
|
|
|||
| ## Upgrading stunnel for RHEL/CentOS | |||
|
|
|||
| By default, when using the EFS mount helper with TLS, it enforces certificate hostname checking. The EFS mount helper uses the `stunnel` program for its TLS functionality. Please note that some versions of Linux do not include a version of `stunnel` that supports TLS features by default. When using such a Linux version, mounting an EFS file system using TLS will fail. | |||
| By default, when using the EFS mount helper with TLS, it enforces certificate hostname checking. The EFS mount helper uses the `stunnel` program for its TLS functionality. Please note that some versions of Linux do not include a version of `stunnel` that supports TLS features by default. When using such a Linux version, mounting an EFS file system using TLS will fail. | |||
There was a problem hiding this comment.
The tail blank space is not needed.
There was a problem hiding this comment.
Sorry about that, Git config stripped whitespace, reverted in 6fa35aa
Cappuccinuo
reviewed
Apr 17, 2020
README.md
Outdated
| @@ -11,6 +11,7 @@ The `efs-utils` package has been verified against the following Linux distributi | |||
| | Amazon Linux 2017.09 | `rpm` | `upstart` | | |||
| | Amazon Linux 2 | `rpm` | `systemd` | | |||
| | CentOS 7 | `rpm` | `systemd` | | |||
| | CentOS 8 | `rpm` | `systemd` | | |||
There was a problem hiding this comment.
Please do not change this file currently, we have a full process of qualifying linux distributions.
Cappuccinuo
reviewed
Apr 17, 2020
mangle-shebangs.sh
Outdated
| @@ -3,9 +3,10 @@ | |||
| SYSTEM_RELEASE_PATH=/etc/system-release | |||
| RHEL8_REGEX="Red Hat Enterprise Linux release 8" | |||
| FEDORA_REGEX="Fedora release" | |||
| CENTOS8_REGEX="CentOS Linux release 8" | |||
|
|
|||
| # RHEL8 and Fedora30+ both treat shebangs of the form "#!/usr/bin/env python" as errors | |||
There was a problem hiding this comment.
Can you also modify the comment?
RHEL8, Fedora30+ and CentOS8 both treat shebangs of the form "#!/usr/bin/env python" as errors
Cappuccinuo
suggested changes
Apr 17, 2020
Merged
I couldn't update the branch for this PR without messing with the history, clean single-commit PR opened -> #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update closed in favor of clean PR #55
Issue #, if available:
#52
Description of changes:
This PR extends the existing
mangle-shebangs.shto include CentOS 8. This will allow the package to be build and installed on CentOS 8.Included in this PR:
mangle-shebangs.shto include CentOS 8- [x] README update to include Centos 8 as supported distroBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.