Release bug fixes #178
Merged
Release bug fixes #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cosign fix, bundle update Signed-off-by: jonahjon <jonahjones094@gmail.com> * upgrading k8s bundle version, and tag Signed-off-by: jonahjon <jonahjones094@gmail.com> * fixing conflict Signed-off-by: jonahjon <jonahjones094@gmail.com> * removing local file Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding release code to test Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding build script changes Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding build Signed-off-by: jonahjon <jonahjones094@gmail.com> * writing aws config for prod account Signed-off-by: jonahjon <jonahjones094@gmail.com> * catting config Signed-off-by: jonahjon <jonahjones094@gmail.com> * trying to fix config Signed-off-by: jonahjon <jonahjones094@gmail.com> * AWS_CONFIG_FILE addition Signed-off-by: jonahjon <jonahjones094@gmail.com> * rearranging file Signed-off-by: jonahjon <jonahjones094@gmail.com> * tweaks to input files Signed-off-by: jonahjon <jonahjones094@gmail.com> * fixing input bundle Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
eks-distro-bot
added
approved
size/M
|
/hold |
Signed-off-by: jonahjon <jonahjones094@gmail.com>
|
/unhold |
ewollesen
suggested changes
May 6, 2022
| ImageIds: imagelookup, | ||
| }) | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "does not exist within the repository") == true { |
There was a problem hiding this comment.
In general, matching errors based on strings like this is a no-no. After the release, let's fix this up.
Signed-off-by: jonahjon <jonahjones094@gmail.com>
ewollesen
suggested changes
May 6, 2022
Signed-off-by: jonahjon <jonahjones094@gmail.com>
ewollesen
approved these changes
May 6, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen, jonahjon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Hit an issue where the correct SHA would exist in the destination repo for promotion, but there would be a tag mismatch, causing the release job to fail. This will synchronize the tags, in addition to checking for SHA existence during the initial promotion from ECR Private to ECR Public.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.