-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release bug fixes #178
Release bug fixes #178
Conversation
* cosign fix, bundle update Signed-off-by: jonahjon <jonahjones094@gmail.com> * upgrading k8s bundle version, and tag Signed-off-by: jonahjon <jonahjones094@gmail.com> * fixing conflict Signed-off-by: jonahjon <jonahjones094@gmail.com> * removing local file Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding release code to test Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding build script changes Signed-off-by: jonahjon <jonahjones094@gmail.com> * adding build Signed-off-by: jonahjon <jonahjones094@gmail.com> * writing aws config for prod account Signed-off-by: jonahjon <jonahjones094@gmail.com> * catting config Signed-off-by: jonahjon <jonahjones094@gmail.com> * trying to fix config Signed-off-by: jonahjon <jonahjones094@gmail.com> * AWS_CONFIG_FILE addition Signed-off-by: jonahjon <jonahjones094@gmail.com> * rearranging file Signed-off-by: jonahjon <jonahjones094@gmail.com> * tweaks to input files Signed-off-by: jonahjon <jonahjones094@gmail.com> * fixing input bundle Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
/hold |
Signed-off-by: jonahjon <jonahjones094@gmail.com>
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error check should be changed. The rest can wait if you want to put them off.
ImageIds: imagelookup, | ||
}) | ||
if err != nil { | ||
if strings.Contains(err.Error(), "does not exist within the repository") == true { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, matching errors based on strings like this is a no-no. After the release, let's fix this up.
Signed-off-by: jonahjon <jonahjones094@gmail.com>
Signed-off-by: jonahjon <jonahjones094@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen, jonahjon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
Hit an issue where the correct SHA would exist in the destination repo for promotion, but there would be a tag mismatch, causing the release job to fail. This will synchronize the tags, in addition to checking for SHA existence during the initial promotion from ECR Private to ECR Public.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.