adding 1.22 bundles #184
adding 1.22 bundles #184
Conversation
Signed-off-by: jonahjon <jonahjones094@gmail.com>
eks-distro-bot
added
approved
size/M
| @@ -45,7 +45,7 @@ ${BASE_DIRECTORY}/generatebundlefile/bin/generatebundlefile \ | |||
| --input ${BASE_DIRECTORY}/generatebundlefile/data/input_121.yaml \ | |||
| --release-profile ${PROFILE} | |||
|
|
|||
| # Create the prod bundle | |||
| # Create the prod bundle for 1.21 | |||
| ${BASE_DIRECTORY}/generatebundlefile/bin/generatebundlefile \ | |||
There was a problem hiding this comment.
{BASE_DIRECTORY}/generatebundlefile/generatebundlefile instead? I don't see bin folder generated on my side.
There was a problem hiding this comment.
The Make build creates a bin folder
| ${BASE_DIRECTORY}/bin/oras push -u AWS -p "${ECR_PASSWORD}" "${IMAGE_REGISTRY}/eks-anywhere-packages-bundles:v1-21-latest" bundle.yaml |
There was a problem hiding this comment.
This kind of cut and paste isn't very sustainable long term.
There was a problem hiding this comment.
Yea Agree, a list of version is probably better.
|
|
||
| cd ${BASE_DIRECTORY}/generatebundlefile/output | ||
| ${BASE_DIRECTORY}/bin/oras push -u AWS -p "${ECR_PASSWORD}" "${IMAGE_REGISTRY}/eks-anywhere-packages-bundles:v1-22-${CODEBUILD_BUILD_NUMBER}" bundle.yaml |
There was a problem hiding this comment.
We're exposing passwords to the process table here.
There was a problem hiding this comment.
There are lots of these. I'm making a ticket to deal with this asap after the release. At least these tokens are short-lived and only visible on AWS-controlled machines (and well, the machine of anyone silly enough to clone and run this code).
There was a problem hiding this comment.
There is an issue about using the ORAS with docker cred helper, but never figured it out.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen, jonahjon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jonahjon jonahjones094@gmail.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.