Allow eksa-controller-manager to remove package bundle controllers #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These permissions will allow the eksa-controller to delete package bundle controller helm installations completely, and without error. The namespace in question is the workload clusters, e.g. eksa-packages-my-workload-cluster. The secret in question is the registry-mirror-secret that is created for workload clusters (regardless of whether or registry mirror is in use). Part of aws#807.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewollesen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
approved
size/M
ewollesen
pushed a commit
to ewollesen/eks-anywhere
that referenced
this pull request
Feb 22, 2023
This change introduces the creation and deletion of a namespaced package bundle controller for workload clusters created via the full cluster lifecycle. This change is dependent on a change in the eks-anywhere-packages repo to grant permissions to the eksa-controller-manager service account. aws/eks-anywhere-packages#833 Without the change above, the reconciliation will log errors removing some resources, which can be left behind. Future commits will add packages installation/deletion via full cluster lifecycle.
|
/lgtm |
ewollesen
pushed a commit
to ewollesen/eks-anywhere
that referenced
this pull request
Mar 1, 2023
This change introduces the creation and deletion of a namespaced package bundle controller for workload clusters created via the full cluster lifecycle. This change is dependent on a change in the eks-anywhere-packages repo to grant permissions to the eksa-controller-manager service account. aws/eks-anywhere-packages#833 Without the change above, the reconciliation will log errors removing some resources, which can be left behind. Future commits will add packages installation/deletion via full cluster lifecycle.
ewollesen
pushed a commit
to ewollesen/eks-anywhere
that referenced
this pull request
Mar 1, 2023
This change introduces the creation and deletion of a namespaced package bundle controller for workload clusters created via the full cluster lifecycle. This change is dependent on a change in the eks-anywhere-packages repo to grant permissions to the eksa-controller-manager service account. aws/eks-anywhere-packages#833 Without the change above, the reconciliation will log errors removing some resources, which can be left behind. Future commits will add packages installation/deletion via full cluster lifecycle.
ewollesen
pushed a commit
to ewollesen/eks-anywhere
that referenced
this pull request
Mar 1, 2023
This change introduces the creation and deletion of a namespaced package bundle controller for workload clusters created via the full cluster lifecycle. This change is dependent on a change in the eks-anywhere-packages repo to grant permissions to the eksa-controller-manager service account. aws/eks-anywhere-packages#833 Without the change above, the reconciliation will log errors removing some resources, which can be left behind. Future commits will add packages installation/deletion via full cluster lifecycle.
ewollesen
pushed a commit
to ewollesen/eks-anywhere
that referenced
this pull request
Mar 1, 2023
This change introduces the creation and deletion of a namespaced package bundle controller for workload clusters created via the full cluster lifecycle. This change is dependent on a change in the eks-anywhere-packages repo to grant permissions to the eksa-controller-manager service account. aws/eks-anywhere-packages#833 Without the change above, the reconciliation will log errors removing some resources, which can be left behind. Future commits will add packages installation/deletion via full cluster lifecycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These permissions will allow the eksa-controller to delete package bundle controller helm installations completely, and without error.
The namespace in question is the workload clusters, e.g. eksa-packages-my-workload-cluster.
The secret in question is the registry-mirror-secret that is created for workload clusters (regardless of whether or registry mirror is in use).
Part of #807.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.