You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some files these packages are imported either without an import alias, or their import aliases are named based on the api version being used. For instance in vsphere.go,
EKS-A imports capi v1alpha3. And anywhere we use variables/functions from that package we have to use v1alpha3
It also imports KCP v1alpha3 but with an alias kubeadmnv1alpha3. And similarly everywhere in that file where variables from that package are used it is referred using kubeadmnv1alpha3
The issue with this is, when we upgrade these packages and start using newer api versions (such as v1beta1), it adds additional changes of refactoring the import alias and its usage.
Instead we can import all capi packages using a generic import alias. For instance
The import for capi v1alpha3 can be named clusterv1.
The import alias kubeadmnv1alpha3 can be renamed to kubeadmv1
Add import alias for all capi/capv imports that can stay constant across different api versions
Rename import aliases that are specific to an api version
The text was updated successfully, but these errors were encountered:
The eks-anywhere code currently imports v1alpha3 api version of the following packages in multiple files:
In some files these packages are imported either without an import alias, or their import aliases are named based on the api version being used. For instance in vsphere.go,
kubeadmnv1alpha3
. And similarly everywhere in that file where variables from that package are used it is referred usingkubeadmnv1alpha3
The issue with this is, when we upgrade these packages and start using newer api versions (such as v1beta1), it adds additional changes of refactoring the import alias and its usage.
Instead we can import all capi packages using a generic import alias. For instance
kubeadmnv1alpha3
can be renamed tokubeadmv1
The text was updated successfully, but these errors were encountered: