Add snow simple flow e2e test #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
g-gaston
reviewed
Apr 20, 2022
|
|
||
| if s.podCidr != "" { | ||
| s.clusterFillers = append(s.clusterFillers, api.WithPodCidr(s.podCidr)) | ||
| } |
There was a problem hiding this comment.
Maybe we should do all of this in the constructor?
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deepakm-ntnx
pushed a commit
to deepakm-ntnx/eks-anywhere
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1108
Description of changes:
Add simple flow e2e test for snow
Testing (if applicable):
make local-e2eBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.