Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra args to improve CIS Benchmark results #192

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

abhay-krishna
Copy link
Member

@abhay-krishna abhay-krishna commented Sep 13, 2021

  • Add extra args to controlplane components for improving CIS benchmark results.
  • Enable auditing with appropriate params

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@jaxesn jaxesn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this cover all the cis issues? I think they may have been some warnings related to tls algorithms?

As follow up PRs, we should add a page in our docs similar to other vendors with our results. It would also be nice to add kube bench as a part of one of e2e test to make sure we dont every break these.

pkg/providers/docker/config/template.yaml Show resolved Hide resolved
pkg/providers/docker/config/template.yaml Outdated Show resolved Hide resolved
@abhay-krishna abhay-krishna force-pushed the cis-benchmark branch 2 times, most recently from 19e15c6 to 9b65238 Compare September 14, 2021 19:21
@abhay-krishna abhay-krishna force-pushed the cis-benchmark branch 2 times, most recently from a13db79 to 0fdf51e Compare September 14, 2021 21:28
@abhay-krishna
Copy link
Member Author

/retest

@abhay-krishna abhay-krishna force-pushed the cis-benchmark branch 4 times, most recently from dbecbb6 to 98f5e17 Compare September 15, 2021 08:32
pkg/providers/docker/config/template.yaml Outdated Show resolved Hide resolved
pkg/providers/docker/config/template.yaml Outdated Show resolved Hide resolved
@abhay-krishna abhay-krishna force-pushed the cis-benchmark branch 3 times, most recently from 47652ce to a304bad Compare September 15, 2021 17:28
@abhay-krishna
Copy link
Member Author

/retest

@abhay-krishna abhay-krishna force-pushed the cis-benchmark branch 2 times, most recently from 51f7c06 to 19706ad Compare September 15, 2021 21:05
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nicely done!

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, micahhausler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,micahhausler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/retest

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
eks-anywhere-presubmit 997f041 link /test eks-anywhere-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhay-krishna abhay-krishna merged commit c531f78 into aws:main Sep 15, 2021
@abhay-krishna abhay-krishna deleted the cis-benchmark branch September 29, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants