-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra args to improve CIS Benchmark results #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cover all the cis issues? I think they may have been some warnings related to tls algorithms?
As follow up PRs, we should add a page in our docs similar to other vendors with our results. It would also be nice to add kube bench as a part of one of e2e test to make sure we dont every break these.
19e15c6
to
9b65238
Compare
a13db79
to
0fdf51e
Compare
/retest |
dbecbb6
to
98f5e17
Compare
47652ce
to
a304bad
Compare
a304bad
to
7e04a8c
Compare
/retest |
51f7c06
to
19706ad
Compare
19706ad
to
997f041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nicely done!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, micahhausler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@abhay-krishna: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.