Clone default transport to honor http proxy config #5488
Conversation
eks-distro-bot
added
do-not-merge/work-in-progress
size/S
Codecov Report
@@ Coverage Diff @@
## main #5488 +/- ##
==========================================
+ Coverage 72.71% 72.94% +0.23%
==========================================
Files 442 442
Lines 36737 36773 +36
==========================================
+ Hits 26713 26825 +112
+ Misses 8424 8335 -89
- Partials 1600 1613 +13
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
g-gaston
force-pushed
the
fix-http-proxy-in-file-reader
branch
from
cf35cc8
to
fc299be
Compare
eks-distro-bot
added
size/L
g-gaston
changed the title
g-gaston
force-pushed
the
fix-http-proxy-in-file-reader
branch
from
fc299be
to
4d2eb3f
Compare
We need to preserve some of the defaults in the default transport. In particular Proxy, which is set to http.ProxyFromEnvironment. This will make the client honor the HTTP_PROXY, HTTPS_PROXY and NO_PROXY env variables.
g-gaston
force-pushed
the
fix-http-proxy-in-file-reader
branch
from
b1786c6
to
cd1e184
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: g-gaston The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.15 |
|
@g-gaston: new pull request created: #5510 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We need to preserve some of the defaults in the default transport. In particular Proxy, which is set to http.ProxyFromEnvironment. This will make the client honor the HTTP_PROXY, HTTPS_PROXY and NO_PROXY env variables.
We need to preserve some of the defaults in the default transport. In particular Proxy, which is set to http.ProxyFromEnvironment. This will make the client honor the HTTP_PROXY, HTTPS_PROXY and NO_PROXY env variables.
Description of changes:
We need to preserve some of the defaults in the default transport. In particular Proxy, which is set to http.ProxyFromEnvironment. This will make the client honor the HTTP_PROXY, HTTPS_PROXY and NO_PROXY env variables.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.