-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for deprecating disableCSI #5927
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5927 +/- ##
=======================================
Coverage 73.62% 73.63%
=======================================
Files 452 452
Lines 37984 37984
=======================================
+ Hits 27966 27969 +3
+ Misses 8395 8393 -2
+ Partials 1623 1622 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Small suggestion.
docs/content/en/docs/getting-started/production-environment/vsphere-getstarted.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Negus <striker57@gmail.com>
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vivek-koppuru The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.16 |
@vivek-koppuru: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@vivek-koppuru: new pull request created: #5949 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Chris Negus <striker57@gmail.com>
Issue #, if available:
#5517
Description of changes:
Add appropriate documentation for deprecating the field as added in the CLI here: #5918
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.