Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for deprecating disableCSI #5927

Merged
merged 1 commit into from
May 30, 2023

Conversation

vivek-koppuru
Copy link
Member

Issue #, if available:
#5517

Description of changes:
Add appropriate documentation for deprecating the field as added in the CLI here: #5918

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #5927 (1afc3a0) into main (e63a2d6) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1afc3a0 differs from pull request most recent head 375385e. Consider uploading reports for the commit 375385e to get more accurate results

@@           Coverage Diff           @@
##             main    #5927   +/-   ##
=======================================
  Coverage   73.62%   73.63%           
=======================================
  Files         452      452           
  Lines       37984    37984           
=======================================
+ Hits        27966    27969    +3     
+ Misses       8395     8393    -2     
+ Partials     1623     1622    -1     

see 1 file with indirect coverage changes

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Small suggestion.

@vivek-koppuru vivek-koppuru changed the title Add documentation for deprecating Add documentation for deprecating disableCSI May 25, 2023
Co-authored-by: Chris Negus <striker57@gmail.com>
@vivek-koppuru
Copy link
Member Author

/approve

@chrisnegus
Copy link
Member

/lgtm

@vivek-koppuru
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vivek-koppuru

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vivek-koppuru
Copy link
Member Author

/cherrypick release-0.16

@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: once the present PR merges, I will cherry-pick it on top of release-0.16 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit d3a5a6a into aws:main May 30, 2023
7 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@vivek-koppuru: new pull request created: #5949

In response to this:

/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ddjjia pushed a commit to ddjjia/eks-anywhere that referenced this pull request Jun 8, 2023
Co-authored-by: Chris Negus <striker57@gmail.com>
@vivek-koppuru vivek-koppuru deleted the docs-csi branch January 26, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants