Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set vsphere creds for CP and CSI #6058

Merged
merged 1 commit into from Jun 22, 2023
Merged

Set vsphere creds for CP and CSI #6058

merged 1 commit into from Jun 22, 2023

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented Jun 20, 2023 •
edited

Issue #, if available:

Description of changes:
Set vsphere creds for CP and CSI. These weren't being set in the reconciler previously.

The data in the secret looks like this

  password: UmlzaGx
  passwordCP: UmlzaGx
  passwordCSI: UmlzaGx
  username: W1hem9uLmNvbQ==
  usernameCP: W1hem9uLmNvbQ==
  usernameCSI: W1hem9uLmNvbQ==

Testing (if applicable):

  • Using updated controller image and tested it out on vsphere clusters.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited

Codecov Report

Merging #6058 (6f34378) into main (a48f297) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #6058      +/-   ##
==========================================
- Coverage   74.85%   74.83%   -0.03%     
==========================================
  Files         447      447              
  Lines       36887    36905      +18     
==========================================
+ Hits        27611    27617       +6     
- Misses       7721     7729       +8     
- Partials     1555     1559       +4
Impacted Files Coverage Δ
pkg/providers/vsphere/reconciler/reconciler.go 74.01% <33.33%> (-4.61%) ⬇️

g-gaston
g-gaston reviewed Jun 21, 2023
View reviewed changes
pkg/providers/vsphere/reconciler/reconciler.go Show resolved Hide resolved
pkg/providers/vsphere/reconciler/reconciler.go

if err := os.Setenv(config.EksavSphereCSIPasswordKey, string(vsphereCSIPassword)); err != nil {
return fmt.Errorf("failed setting env %s: %v", config.EksavSphereCSIPasswordKey, err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can probably simplify this code by having a mapping between key in the secret and env var and just loop over them

@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 21, 2023
@mitalipaygude
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitalipaygude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude mitalipaygude merged commit 13212a9 into aws:main Jun 22, 2023
8 of 10 checks passed
@mitalipaygude
Copy link
Member Author

/cherrypick release-0.16

@eks-distro-pr-bot
Copy link
Contributor

@mitalipaygude: new pull request created: #6070

In response to this:

/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot eks-distro-pr-bot mentioned this pull request Jun 22, 2023
Merged
tatlat pushed a commit to tatlat/eks-anywhere that referenced this pull request Jun 28, 2023
@mitalipaygude @tatlat
Set vsphere creds for CP and CSI (aws#6058)
651df69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-gaston g-gaston g-gaston approved these changes

Assignees

@g-gaston g-gaston

Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mitalipaygude @eks-distro-bot @eks-distro-pr-bot @g-gaston