Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept service account issuer for Pod based IAM #640

Merged
merged 1 commit into from Nov 17, 2021

Conversation

mrajashree
Copy link
Contributor

@mrajashree mrajashree commented Nov 16, 2021

Issue #, if available: #601

Description of changes: EKS-A users can leverage the IAM Role for Service Account (IRSA) feature following the special instructions for DIY Kubernetes to enable AWS authentication. This commit enables that by allowing the configuration of service-account-issuer flag for kube-apiserver with the identity issuer URL as per the self-hosted setup guide.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna abhay-krishna added approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2021
@mrajashree mrajashree force-pushed the apiserverFlags branch 4 times, most recently from c8f3709 to b8c91cb Compare November 16, 2021 18:00
@abhay-krishna abhay-krishna added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2021
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to the Docker provider too?

@mrajashree mrajashree force-pushed the apiserverFlags branch 3 times, most recently from f6b1a30 to 42d5948 Compare November 17, 2021 20:09
EKS-A users can leverage the IAM Role for Service Account (IRSA)
feature following the [special instructions for DIY Kubernetes]
(https://github.com/aws/amazon-eks-pod-identity-webhook/blob/master/SELF_HOSTED_SETUP.md)
to enable AWS authentication. This commit enables that by allowing
the configuration of service-account-issuer flag for kube-apiserver
with the identity issuer URL as per the self-hosted setup guide.
Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abhay-krishna
Copy link
Member

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, mrajashree

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [micahhausler,mrajashree]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants