CLI changes for enabling modular upgrades for tinkerbell provider #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
eks-distro-bot
added
the
size/M
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6735 +/- ##
==========================================
+ Coverage 71.78% 71.85% +0.06%
==========================================
Files 531 531
Lines 41295 41337 +42
==========================================
+ Hits 29642 29701 +59
+ Misses 9993 9971 -22
- Partials 1660 1665 +5
☔ View full report in Codecov by Sentry. |
eks-distro-bot
added
size/L
chrisdoherty4
approved these changes
Oct 9, 2023
rahulbabu95
force-pushed
the
cli/tink-mod-upgrades
branch
from
b0758fc
to
5a490f7
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
rahulbabu95
force-pushed
the
cli/tink-mod-upgrades
branch
from
c304019
to
a4402a6
Compare
eks-distro-bot
added
size/XXL
…late Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
|
/retest-required |
|
/lgtm |
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Modular Upgrades are not enabled in Tinkerbell Provider currently because, we just have one OSImageUrl field that can be specified in data center config to be used by all machine configs in the cluster.
Description of changes:
Enable specifying OSImageUrl field per machine config to help facilitate modular upgrades. For backward compatibility continue supporting OSImageUrl field at data center config too and eventually deprecate.
Testing (if applicable):
Manually tested upgrading CP and worker separately
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.