Fix incorrect regex for matching curated package registry URL #7049
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/XS
chrisdoherty4
force-pushed
the
patch/invalid-regex
branch
from
f48b29c
to
787929b
Compare
chrisdoherty4
force-pushed
the
patch/invalid-regex
branch
from
787929b
to
a7b36b5
Compare
eks-distro-bot
added
size/M
chrisdoherty4
force-pushed
the
patch/invalid-regex
branch
from
a7b36b5
to
a6034bc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7049 +/- ##
=======================================
Coverage 71.47% 71.47%
=======================================
Files 538 538
Lines 41882 41882
=======================================
Hits 29934 29934
Misses 10270 10270
Partials 1678 1678 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-0.18 |
|
@chrisdoherty4: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@chrisdoherty4: new pull request created: #7053 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to https://github.com/aws/eks-anywhere/security/code-scanning/4.
Registry mirror configuration using namespaced registries requires users to specify the curated packages registry.
We have special handling for the curated packages URL and identify URLs of any region using regex. However, the regex was incorrect and matched invalid URLs such as
783794618700&dkr&ecr&amazonaws&com. This is because the string is also used in containerd config that supports wildcard matching (as used in the string).This change separates regex uses from containerd uses ensuring we correctly match curated packages URLs.