-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kubelet configuration for control plane and worker nodes - vsphere #8179
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8179 +/- ##
==========================================
- Coverage 73.42% 73.42% -0.01%
==========================================
Files 577 577
Lines 35944 35957 +13
==========================================
+ Hits 26391 26400 +9
- Misses 7884 7886 +2
- Partials 1669 1671 +2 ☔ View full report in Codecov by Sentry. |
5a44b26
to
a3b67ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a3b67ca
to
3a7d2bd
Compare
New changes are detected. LGTM label has been removed. |
3a7d2bd
to
a25d061
Compare
Issue #, if available:
Description of changes:
This PR adds a new field KubeletConfiguration in the eksa spec for control plane and worker node configuration. This is an unstructured object that is of the kind value KubeletConfiguration. This PR adds the code for vSphere provider.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.