Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts should be published and indexed on merge to master #53

Open
max-rocket-internet opened this issue Dec 17, 2019 · 9 comments
Open
Labels
enhancement New feature or request

Comments

@max-rocket-internet
Copy link
Contributor

It's just confusing for everyone otherwise.

For example:
#46
#36

@jaypipes jaypipes added the enhancement New feature or request label Dec 17, 2019
@jaypipes
Copy link
Contributor

Not sure about every merge to master, but I suppose I could support auto-publish/index when a new tag is pushed to the master repos of the underlying projects

@max-rocket-internet
Copy link
Contributor Author

No, I mean like someone makes a PR to update a chart in this repo. The PR is reviewed, the chart version is bumped and the the PR is merged. At this point, we can see it in master but we can't use it as it hasn't been published yet. That is what those 2 issues above are about.

My point is: once a PR has been approved and merged, it should be published and available to use via Helm immediately. That's how the main stable charts repo does it. It's confusing if people have to wait until a tag is created for this whole repo. See what I mean?

@stefanprodan
Copy link
Collaborator

It takes many hours for the stable charts to be published on GPC. The current publishing flow allows us to bundle several PRs in a release and have a change log in GitHub releases. I think it's the reviewer responsibility to do a release or not after the merge and also document the changes.

@max-rocket-internet
Copy link
Contributor Author

It takes many hours for the stable charts to be published on GPC

It takes less than a minute in our CI with many more charts, feel free to copy it: https://github.com/deliveryhero/helm-charts/blob/master/.github/workflows/push-chart.yaml

😃

@max-rocket-internet
Copy link
Contributor Author

@jaypipes @M00nF1sh @fawadkhaliq can we address what I mention in this issue?

It's so frustrating having to push to get a chart update merged and THEN have to wait/push for a new release to be made.

Another example is #345

Not sure about every merge to master

Why not? That's a totally normal work flow. The old Helm stable repo did this and I don't know how bitnami do it but a PR merged 2 hours ago is already in their index 😅

@max-rocket-internet
Copy link
Contributor Author

@kishorj @bwagner5

Look at all these issues that could be prevented:

#272
#281
#247
#244

@max-rocket-internet
Copy link
Contributor Author

And more

#185
#193

I think you get my point 🙂

@jwenz723
Copy link
Contributor

jwenz723 commented Mar 23, 2021

I would love to see this functionality built in as well. My PR, #472, got merged 11 days ago by @fawadkhaliq. I still cannot make use of the features in my PR because a released version of the helm chart has not been published yet.

@kazu
Copy link

kazu commented Apr 23, 2021

when will the newer version including the aws-for-fluent-bit chart (> 0.1.7) publish?
these PR already is merged to master

#446
#492
#353
#491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants