Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-node-termination-handler] Add 0.3.0 Chart to Repository Index #46

Closed
mrkwtz opened this issue Dec 6, 2019 · 3 comments
Closed

Comments

@mrkwtz
Copy link

mrkwtz commented Dec 6, 2019

Hey,

right now the latest chart version in your repo for the "aws-node-termination-handler" is 0.2.0. The master branch is on version 0.3.0 but this version is nowhere to be found.

The 0.2.0 version does not align with your chart description on master, because in the 0.2.0 chart you use .Values.namespace to set the namespace for the subject in the clusterrolebinding. In the 0.3.0 values description this is not mentioned and the 0.3.0 chart uses (rightfully so) the .Release.Namespace value.

@max-rocket-internet
Copy link
Contributor

See #36

@mrkwtz
Copy link
Author

mrkwtz commented Dec 6, 2019

Thx. @nckturner could you add a tag to trigger the build?

@nckturner
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants