Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-for-fluent-bit: service account fix #208

Merged
merged 3 commits into from
Oct 12, 2020

Conversation

fmedery
Copy link

@fmedery fmedery commented Jul 13, 2020

Issue #, if available:

  • When deploying with Values.serviceAccount.create=false the serviceaccount.name value == default.
  • Value.serviceaccount.name was not in the documentation.

Description of changes:

  • Remove dependency between namespace creation and serviceaccount name
  • update the default value of serviceaccount name to aws-for-fluent-bit.fullname
  • add Values.serviceAccount.name to the documentation
  • minor tweaks of README based on MK linter

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Frederic Medery added 2 commits July 13, 2020 08:14
* Remove dependency between namespace creation and serviceaccount name
* update the default serviceaccount name
* add `Values.serviceAccount.name` to the documentation
@fmedery fmedery changed the title Irsa service account fix service account fix Jul 13, 2020
@fmedery fmedery changed the title service account fix aws-for-fluent-bit: service account fix Jul 13, 2020
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fmedery! :)

@jaypipes jaypipes merged commit 8c0db8a into aws:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants