Don't schedule pods in fargate nodes #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
approved these changes
Sep 30, 2020
Comment on lines
+22
to
+30
| affinity: | ||
| nodeAffinity: | ||
| requiredDuringSchedulingIgnoredDuringExecution: | ||
| nodeSelectorTerms: | ||
| - matchExpressions: | ||
| - key: "eks.amazonaws.com/compute-type" | ||
| operator: NotIn | ||
| values: | ||
| - fargate |
There was a problem hiding this comment.
Thanks, looks good. We should probably add checks for OS and Arch as well, since the default Calico image will only work on Linux on amd64. That can be a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #177
Description of changes:
This resolves an issue where the aws calico pods tries to get scheduled on a fargate pod, adding affinity to make sure that it will not be scheduled on fargate.
This solution is taken from a similar problem with the
aws-node-termination-handlerchart in commit 86c6e24 so if there is a different method of solving this let me knowBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.