feat: Add chart for cloudwatch-metrics #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
suggested changes
Oct 12, 2020
| | `image.tag` | Image tag to deploy | `1.247345.36b249270` | ||
| | `image.pullPolicy` | Pull policy for the image | `IfNotPresent` | ✔ | ||
| | `clusterName` | Name of your cluster | `cluster_name` | ✔ | ||
| | `serviceAccount.create` | Whether a new service account should be created | `true` | |
There was a problem hiding this comment.
There is also the serviceAccount.name field.
gazal-k
force-pushed
the
cloudwatch-metrics
branch
from
3aeb922
to
a0e61d5
Compare
jaypipes
suggested changes
Oct 12, 2020
| {{- if .Values.serviceAccount.create -}} | ||
| {{ default (include "aws-cloudwatch-metrics.fullname" .) .Values.serviceAccount.name }} | ||
| {{- else -}} | ||
| {{ default "default" .Values.serviceAccount.name }} |
There was a problem hiding this comment.
And one other issue I see is that this is copying in a mistake that was fixed here: 8c0db8a
Basically, you need to remove the {{ if block around the Values.serviceAccount.create check above...
There was a problem hiding this comment.
Hi. this service account name template is not used in your cluster role binding. There it just uses {{ include "aws-cloudwatch-metrics.fullname" . }}. It should also use the template aws-cloudwatch-metrics.serviceAccountName in role binding I think.
gazal-k
force-pushed
the
cloudwatch-metrics
branch
from
a0e61d5
to
701a0c9
Compare
Helm chart created from reference here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Container-Insights-setup-metrics.html
gazal-k
force-pushed
the
cloudwatch-metrics
branch
from
701a0c9
to
e7caa3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm chart created from reference here: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Container-Insights-setup-metrics.html
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.