[aws-pod-identity-webhook] Adding chart #286
Conversation
max-rocket-internet
changed the title
| @@ -0,0 +1,18 @@ | |||
| apiVersion: v1 | |||
| appVersion: "c0431e1" | |||
There was a problem hiding this comment.
please put the appVersion directly below the version field to keep them together, like the n-t-h chart does:
https://github.com/aws/eks-charts/blob/master/stable/aws-node-termination-handler/Chart.yaml#L4-L5
There was a problem hiding this comment.
Also, the latest semver release of pod identity webhook is v0.2.0. Did you want the above specific Git commit for some reason?
There was a problem hiding this comment.
Did you want the above specific Git commit for some reason?
Yes because this PR (including the identical previous PR) has dragging on over a year so it's probably from when it wasn't released on docker hub
There was a problem hiding this comment.
Edit: there isn't proper tags pushed to docker hub: https://hub.docker.com/r/amazon/amazon-eks-pod-identity-webhook/tags
|
@jaypipes this PR has been going on and on very slowly for over a year now. I don't really have the patience for it. I'm sure you can understand 😅 Please just either merge or close it. |
…ause the `eks-charts` repository takes forever to merge aws/eks-charts#286
|
Looks like there is a helm chart for this that was included in this PR eks-distro-build-tooling/pull/56 Path to README for it: |
|
Any idea when and if this is going to ever get merged? Thanks. |
|
@ekristen try to tag the repo maintainers in the comments 😉 |
|
@jaypipes @jim-barber-he any chance this is going to get merged? Would like to use it and prefer to install using helm. Thanks. |
|
I saw you recently merged PRs here. Can you take a look please? Or ping the right person? |
|
In meantime, I provide a helm chart which optionally support the cert-manager or static generated tls certificates. https://github.com/jkroepke/helm-charts/tree/main/charts/amazon-eks-pod-identity-webhook |
|
Would be nice to have it |
|
Seems like this needs a bump. |
|
Any chance of this getting merged? |
|
Hi @jaypipes @jim-barber-he any chance to review and merge? |
|
waiting long time... |
|
|
Related issues:
aws/amazon-eks-pod-identity-webhook#4
aws/containers-roadmap#23
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.