[aws-for-fluent-bit] Add log_retention_days to CloudWatch plugin #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws-for-fluent-bit chart was not exposing the configuration for log_retention_days provided by the original [CloudWatch Plugin](https://github.com/aws/amazon-cloudwatch-logs-for-fluent-bit)
mickeypash
changed the title
mforutan
reviewed
Oct 27, 2020
|
Any other feedback? |
mforutan
approved these changes
Oct 29, 2020
|
Is there anything I can do to help get this prioritised or merged? |
fawadkhaliq
approved these changes
Jan 8, 2021
|
So I see a new version has been released for the |
|
@mickeypash that new release just happened before this merge so we have to wait for the next release to see these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
aws-for-fluent-bitchart was not exposing the configuration forlog_retention_daysprovided by the original CloudWatch Plugin.This change attempts to address this, thus allowing users of the chart to set the number of days they would like their log streams to be kept for.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.